If new queries have been introduced or existing queries have been updated, you are required to provide: The bot also checks that migrations are correctly It is not required for the author to provide this output in the merge request description,īut doing so may be helpful for reviewers. If new migrations are introduced, database reviewers must review the output of both migrating ( db:migrate)Īnd rolling back ( db:rollback) for all migrations.ĭb:check-migrations pipeline job) that provides this output in the CI job logs. If your merge request description does not include these items, the review is reassigned back to the author. You must provide the following artifacts when you request a ~database review. Point out specific queries for review and there are no overlyĬomplex queries, it is enough to concentrate on reviewing the Queries in the change and review those closer. These metrics could have complex queries over large tables.Ī database reviewer is expected to look out for overly complex Changes in Service Data metrics that use count, distinct_count, estimate_batch_distinct_count and sum.Not complex queries are being introduced and if they require a Generally up to the author of a merge request to decide whether or Changes that produce SQL queries that are beyond the obvious.migration or ActiveRecord helpers in lib/gitlab/database/.Changes that touch the database schema or perform data migrations,.Refer to ourĬode review guide for broader advice and best This page is specific to database reviews.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |